Attachment 8586 Details for Bug 6502 – proposed fix

[patch] proposed fix

xorg-xserver-1.1.1-randr-fix.patch (text/plain), 1.20 KB, created by Marius Gedminas on 2007-02-02 14:34:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marius Gedminas

Created: 2007-02-02 14:34:06 UTC

Size: 1.20 KB

patch

obsolete

>Proposed fix for https://bugs.freedesktop.org/show_bug.cgi?id=6502
>
>--- randr.c.orig	2006-07-05 21:31:44.000000000 +0300
>+++ randr.c	2007-02-03 00:00:10.000000000 +0200
>@@ -723,7 +723,6 @@
>     pScrPriv = rrGetScrPriv(pScreen);
>     
>     time = ClientTimeToServerTime(stuff->timestamp);
>-    configTime = ClientTimeToServerTime(stuff->configTimestamp);
>     
>     oldWidth = pScreen->width;
>     oldHeight = pScreen->height;
>@@ -738,11 +737,15 @@
> 	return BadAlloc;
>     
>     /*
>-     * if the client's config timestamp is not the same as the last config
>+     * If the client's config timestamp is not the same as the last config
>      * timestamp, then the config information isn't up-to-date and
>-     * can't even be validated
>+     * can't even be validated.
>+     *
>+     * Note that the client only knows about the milliseconds part of the
>+     * timestamp, so using CompareTimeStamps here would cause randr to suddenly
>+     * stop working after several hours have passed (freedesktop bug #6502).
>      */
>-    if (CompareTimeStamps (configTime, pScrPriv->lastConfigTime) != 0)
>+    if (stuff->configTimestamp != pScrPriv->lastConfigTime.milliseconds)
>     {
> 	rep.status = RRSetConfigInvalidConfigTime;
> 	goto sendReply;

Actions: View | Splinter Review

Attachments on bug 6502: 5577 | 5578 | 6494 | 6495 | 8287 | 8288 | 8585 | 8586 | 11114

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.