Attachment 85782 Details for Bug 69329 – Patch for 1.7

[patch] Patch for 1.7

0003-Fix-an-incorrect-sizeof.patch (text/plain), 1.02 KB, created by Sviatoslav Chagaev on 2013-09-13 17:14:26 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Sviatoslav Chagaev

Created: 2013-09-13 17:14:26 UTC

Size: 1.02 KB

patch

obsolete

>From 5a4ab482670ede01a51144529509a99f3228b27d Mon Sep 17 00:00:00 2001
>From: Sviatoslav Chagaev <sviatoslav.chagaev@gmail.com>
>Date: Fri, 13 Sep 2013 19:02:49 +0300
>Subject: [PATCH 3/3] Fix an incorrect sizeof.
>
>Fix an incorrect sizeof which leads to allocation of more memory than
>actually needed.
>---
> tools/dbus-monitor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/tools/dbus-monitor.c b/tools/dbus-monitor.c
>index a4b5478..42cc508 100644
>--- a/tools/dbus-monitor.c
>+++ b/tools/dbus-monitor.c
>@@ -310,7 +310,7 @@ main (int argc, char *argv[])
>           filters = (char **) realloc (filters, numFilters * sizeof (char *));
>           if (filters == NULL)
>             oom ("adding a new filter slot");
>-          filters[j] = (char *) malloc (filter_len * sizeof (char *));
>+          filters[j] = (char *) malloc (filter_len * sizeof (char));
>           if (filters[j] == NULL)
>             oom ("adding a new filter");
>           snprintf (filters[j], filter_len, "%s,%s", EAVESDROPPING_RULE, arg);
>-- 
>1.8.3.1
>

Actions: View | Splinter Review

Attachments on bug 69329: 85781 | 85782

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.