Attachment 85532 Details for Bug 69165 – [PATCH 2/2] Use the function argument rather than hard-code

[patch] [PATCH 2/2] Use the function argument rather than hard-code

0002-Use-the-function-argument-rather-than-hard-code.patch (text/plain), 1.09 KB, created by Chengwei Yang on 2013-09-10 06:01:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chengwei Yang

Created: 2013-09-10 06:01:14 UTC

Size: 1.09 KB

patch

obsolete

>From 7000fc218cca24905d2ffba763cb1a14c9013fe5 Mon Sep 17 00:00:00 2001
>From: Chengwei Yang <chengwei.yang@intel.com>
>Date: Fri, 6 Sep 2013 13:48:38 +0800
>Subject: [PATCH 2/2] Use the function argument rather than hard-code
>
>The function dbus_connection_set_route_peer_messages() take a bool
>argument, however, in the implementation, it always hard-code to TRUE
>rather than take its bool argument.
>
>This fix to use the function argument, meanwhile, this change doesn't
>has any effect in practice since this function only invoked once with
>a TRUE argument.
>---
> dbus/dbus-connection.c |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/dbus/dbus-connection.c b/dbus/dbus-connection.c
>index 759a649..f0b6871 100644
>--- a/dbus/dbus-connection.c
>+++ b/dbus/dbus-connection.c
>@@ -5455,7 +5455,7 @@ dbus_connection_set_route_peer_messages (DBusConnection             *connection,
>   _dbus_return_if_fail (connection != NULL);
>   
>   CONNECTION_LOCK (connection);
>-  connection->route_peer_messages = TRUE;
>+  connection->route_peer_messages = value;
>   CONNECTION_UNLOCK (connection);
> }
> 
>-- 
>1.7.9.5
>

Actions: View | Splinter Review

Attachments on bug 69165: 85531 | 85532

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.