Attachment 85531 Details for Bug 69165 – [PATCH 1/2] Fix pass wrong type of argument to function

[patch] [PATCH 1/2] Fix pass wrong type of argument to function

0001-Fix-pass-wrong-type-of-argument-to-function.patch (text/plain), 1.03 KB, created by Chengwei Yang on 2013-09-10 06:00:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chengwei Yang

Created: 2013-09-10 06:00:44 UTC

Size: 1.03 KB

patch

obsolete

>From a486c96547a795de0795a9011df43e1ff5a7580b Mon Sep 17 00:00:00 2001
>From: Chengwei Yang <chengwei.yang@intel.com>
>Date: Fri, 6 Sep 2013 11:26:44 +0800
>Subject: [PATCH 1/2] Fix pass wrong type of argument to function
>
>The last argument of function _dbus_transport_new_for_socket() is
>declared as const DBusString *. However, it is passed as a bool value.
>Although the value of FALSE equals NULL in fact, this is an incorrect
>use of function.
>---
> dbus/dbus-server-socket.c |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/dbus/dbus-server-socket.c b/dbus/dbus-server-socket.c
>index ae4b602..8084764 100644
>--- a/dbus/dbus-server-socket.c
>+++ b/dbus/dbus-server-socket.c
>@@ -101,7 +101,7 @@ handle_new_client_fd_and_unlock (DBusServer *server,
>       return TRUE;
>     }
> 
>-  transport = _dbus_transport_new_for_socket (client_fd, &server->guid_hex, FALSE);
>+  transport = _dbus_transport_new_for_socket (client_fd, &server->guid_hex, NULL);
>   if (transport == NULL)
>     {
>       _dbus_close_socket (client_fd, NULL);
>-- 
>1.7.9.5
>

Actions: View | Splinter Review

Attachments on bug 69165: 85531 | 85532

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.