Attachment 84709 Details for Bug 68505 – libdbus-1.la: have proper dependencies on Windows

[patch] libdbus-1.la: have proper dependencies on Windows

0001-libdbus-1.la-have-proper-dependencies-on-Windows.patch (text/plain), 1.13 KB, created by Simon McVittie on 2013-08-27 12:58:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2013-08-27 12:58:36 UTC

Size: 1.13 KB

patch

obsolete

>From 66b320b58504d41469a6e6a0023ad79644bf5a5d Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Tue, 27 Aug 2013 13:53:42 +0100
>Subject: [PATCH] libdbus-1.la: have proper dependencies on Windows
>
>Assigning to libdbus_1_la_DEPENDENCIES defeats Automake's normal
>dependency logic, which makes libdbus-1.la depend on all the
>static libraries that will go into it (it still had a corrct dependency
>on the other objects, which go through a separate variable).
>This meant libdbus-init-win wasn't necessarily built first.
>
>Use EXTRA_libdbus_1_la_DEPENDENCIES to avoid that problem.
>
>Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Bug: https://bugs.freedesktop.org/show_bug.cgi?id=68505
>---
> dbus/Makefile.am | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/dbus/Makefile.am b/dbus/Makefile.am
>index e118cbb..0f9033d 100644
>--- a/dbus/Makefile.am
>+++ b/dbus/Makefile.am
>@@ -39,7 +39,7 @@ dbus_res_ldflag = -Wl,$(dbus_res)
> no_undefined = -no-undefined
> export_symbols =
> 
>-libdbus_1_la_DEPENDENCIES = $(dbus_res)
>+EXTRA_libdbus_1_la_DEPENDENCIES = $(dbus_res)
> intllibs =
> 
> else
>-- 
>1.8.4.rc3
>

Actions: View | Splinter Review

Attachments on bug 68505: 84709

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.