Attachment 81465 Details for Bug 48277 – Document that GNU make is required

[patch] Document that GNU make is required

0001-Document-that-GNU-make-is-required.patch (text/plain), 1.50 KB, created by Simon McVittie on 2013-06-26 12:01:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2013-06-26 12:01:54 UTC

Size: 1.50 KB

patch

obsolete

>From dad7fd9d8915e1aea0d24158565b607a1d272a9b Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Wed, 26 Jun 2013 12:27:09 +0100
>Subject: [PATCH 1/2] Document that GNU make is required
>
>In theory the Autotools build system supports any "make" implementation,
>but there are no regular contributors who test with BSD make, so the
>inevitable result is that only GNU make actually works (fd.o #48277).
>
>Apparently there's only one GNUism at the moment, which is fixable,
>but that means repeating ourselves a bit more. If we instead document
>that GNU make is required, we can simplify the Makefiles over time
>by using extensions like $(patsubst), leading to a less error-prone
>build system.
>
>Bug: https://bugs.freedesktop.org/show_bug.cgi?id=48277
>Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
>---
> README | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/README b/README
>index fd832ca..aea8330 100644
>--- a/README
>+++ b/README
>@@ -66,7 +66,9 @@ Configuration
> dbus could be build by using autotools or cmake. 
> 
> When using autotools the configure step is initiated by running ./configure 
>-with or without additional configuration flags. 
>+with or without additional configuration flags. dbus requires GNU Make
>+(on BSD systems, this is typically called gmake) or a "make" implementation
>+with compatible extensions.
> 
> When using cmake the configure step is initiated by running the cmake 
> program with or without additional configuration flags. 
>-- 
>1.8.3.1
>

Actions: View | Splinter Review

Attachments on bug 48277: 59461 | 81465 | 81466

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.