Attachment 80489 Details for Bug 65518 – tp_debug_client_get_messages_finish: fix annotation

[patch] tp_debug_client_get_messages_finish: fix annotation

0001-tp_debug_client_get_messages_finish-fix-annotation.patch (text/plain), 1.19 KB, created by Simon McVittie on 2013-06-07 17:30:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2013-06-07 17:30:47 UTC

Size: 1.19 KB

patch

obsolete

>From b7476291eeea2e7104253bd046cfe7fbc1692ce5 Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Fri, 7 Jun 2013 17:42:15 +0100
>Subject: [PATCH 1/2] tp_debug_client_get_messages_finish: fix annotation
>
>Returning a GPtrArray with (transfer full) means the caller is expected
>to do the equivalent of:
>
>    g_ptr_array_foreach (pa, (GFunc) g_free, NULL);
>    g_ptr_array_unref (pa);
>
>whereas we just want them to unref it. This crashed my g-i-based
>debug-client.
>---
> telepathy-glib/debug-client.c |    4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/telepathy-glib/debug-client.c b/telepathy-glib/debug-client.c
>index 113ac3f..89712db 100644
>--- a/telepathy-glib/debug-client.c
>+++ b/telepathy-glib/debug-client.c
>@@ -536,8 +536,8 @@ tp_debug_client_get_messages_async (
>  *
>  * Finishes tp_debug_client_set_enabled_async().
>  *
>- * Returns: (transfer full) (type GLib.PtrArray) (element-type TelepathyGLib.DebugMessage):
>- * a #GPtrArray of #TpDebugMessage
>+ * Returns: (transfer container) (type GLib.PtrArray) (element-type TelepathyGLib.DebugMessage):
>+ * a #GPtrArray of #TpDebugMessage, free with g_ptr_array_unref()
>  *
>  * Since: 0.19.0
>  */
>-- 
>1.7.10.4
>

Actions: View | Splinter Review

Attachments on bug 65518: 80489 | 80490

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.