Attachment 76719 Details for Bug 61998 – fix-status-io-error.patch

[patch] fix-status-io-error.patch

fix-status-io-error.patch (text/plain), 1.12 KB, created by Phillip Susi on 2013-03-18 23:10:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Phillip Susi

Created: 2013-03-18 23:10:59 UTC

Size: 1.12 KB

patch

obsolete

>Author: Phillip Susi <psusi@ubuntu.com>
>Subject: fix an incorrect IO error reading SMART status
>Description: The read SMART status command's return status
> was testing for a success/failure value that included 8
> bits that are "N/A" according to the standard, and required
> that they be zeros.  At least some drives do not fill them
> with zeros, so correct this by masking off the undefined
> bits.
>
>Index: b/atasmart.c
>===================================================================
>--- a/atasmart.c
>+++ b/atasmart.c
>@@ -925,10 +925,10 @@
>         /* SAT/USB bridges truncate packets, so we only check for 4F,
>          * not for 2C on those */
>         if ((d->type == SK_DISK_TYPE_ATA_PASSTHROUGH_12 || cmd[3] == htons(0x00C2U)) &&
>-            cmd[4] == htons(0x4F00U))
>+            (cmd[4] & htons(0xFF00U)) == htons(0x4F00U))
>                 *good = TRUE;
>         else if ((d->type == SK_DISK_TYPE_ATA_PASSTHROUGH_12 || cmd[3] == htons(0x002CU)) &&
>-                 cmd[4] == htons(0xF400U))
>+                 (cmd[4] & htons(0xFF00U)) == htons(0xF400U))
>                 *good = FALSE;
>         else {
>                 errno = EIO;

Actions: View | Splinter Review

Attachments on bug 61998: 76719 | 122509

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.