Attachment 74877 Details for Bug 45729 – possible patch

[patch] possible patch

0001-drm-don-t-add-inferred-modes-for-monitors-that-don-t.patch (text/plain), 1.79 KB, created by Paulo Zanoni on 2013-02-15 15:41:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Paulo Zanoni

Created: 2013-02-15 15:41:00 UTC

Size: 1.79 KB

patch

obsolete

>From ad60df6764c25a203642fb59c39e9c53375f6587 Mon Sep 17 00:00:00 2001
>From: Paulo Zanoni <paulo.r.zanoni@intel.com>
>Date: Fri, 15 Feb 2013 12:38:01 -0200
>Subject: [PATCH] drm: don't add inferred modes for monitors that don't
> support them
>
>If bit 0 of the features byte (0x18) is set to 0, then, according to
>the EDID spec, "the display is non-continuous frequency (multi-mode)
>and is only specified to accept the video timing formats that are
>listed in Base EDID and certain Extension Blocks".
>
>For more information, please see the EDID spec, check the notes of the
>table that explains the "Feature Support" byte (18h) and also the
>notes on the tables of the section that explains "Display Range Limits
>& Additional Timing Description Definition (tag #FDh)".
>
>Cc: Adam Jackson <ajax@redhat.com>
>Cc: stable@vger.kernel.org
>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=45729
>Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
>---
> drivers/gpu/drm/drm_edid.c |    3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>I still need to ask some specific people to test the patch, but I
>believe it is correct.
>
>diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
>index a3a3b61..6a003b6 100644
>--- a/drivers/gpu/drm/drm_edid.c
>+++ b/drivers/gpu/drm/drm_edid.c
>@@ -2053,7 +2053,8 @@ int drm_add_edid_modes(struct drm_connector *connector, struct edid *edid)
> 	num_modes += add_cvt_modes(connector, edid);
> 	num_modes += add_standard_modes(connector, edid);
> 	num_modes += add_established_modes(connector, edid);
>-	num_modes += add_inferred_modes(connector, edid);
>+	if (edid->features & DRM_EDID_FEATURE_DEFAULT_GTF)
>+		num_modes += add_inferred_modes(connector, edid);
> 	num_modes += add_cea_modes(connector, edid);
> 
> 	if (quirks & (EDID_QUIRK_PREFER_LARGE_60 | EDID_QUIRK_PREFER_LARGE_75))
>-- 
>1.7.10.4
>

Actions: View | Splinter Review

Attachments on bug 45729: 56793 | 57007 | 59873 | 59926 | 60048 | 61262 | 61924 | 62310 | 66201 | 66902 | 74877

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.