Attachment 65171 Details for Bug 45236 – Explicitly specify the form type of every Yts form field

[patch] Explicitly specify the form type of every Yts form field

0001-Explicitly-specify-the-form-type-of-every-Yts-form-f.patch (text/plain), 1.41 KB, created by Simon McVittie on 2012-08-06 12:34:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2012-08-06 12:34:21 UTC

Size: 1.41 KB

patch

obsolete

>From 82b97c0ecae5c14a77ab1174cde14c8183f30c94 Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Mon, 6 Aug 2012 11:53:48 +0100
>Subject: [PATCH 1/3] Explicitly specify the form type of every Yts form field
>
>Otherwise, the client side will have to guess it: text-multi if there
>is more than one of something, otherwise text-single.
>---
> plugin-base/caps-manager.c |    3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/plugin-base/caps-manager.c b/plugin-base/caps-manager.c
>index cf8c8e0..76fe11d 100644
>--- a/plugin-base/caps-manager.c
>+++ b/plugin-base/caps-manager.c
>@@ -135,6 +135,7 @@ make_new_data_form (const gchar *uid,
> 
>       '(', "field",
>         '@', "var", "type",
>+        '@', "type", "text-single",
>         '(', "value",
>           '$', yts_type,
>         ')',
>@@ -150,6 +151,7 @@ make_new_data_form (const gchar *uid,
>     {
>       tmp = wocky_node_add_child (node, "field");
>       wocky_node_set_attribute (tmp, "var", "name");
>+      wocky_node_set_attribute (tmp, "type", "text-multi");
>       g_ptr_array_foreach (names, add_value_to_field, tmp);
>     }
> 
>@@ -157,6 +159,7 @@ make_new_data_form (const gchar *uid,
>     {
>       tmp = wocky_node_add_child (node, "field");
>       wocky_node_set_attribute (tmp, "var", "capabilities");
>+      wocky_node_set_attribute (tmp, "type", "text-multi");
>       g_ptr_array_foreach (caps, add_value_to_field, tmp);
>     }
> 
>-- 
>1.7.10.4
>

Actions: View | Splinter Review

Attachments on bug 45236: 65171 | 65172

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.