Attachment 61958 Details for Bug 49372 – tests/lib: Stop using tp_connection_new()

[patch] tests/lib: Stop using tp_connection_new()

testslib-Stop-using-tpconnectionnew.patch (text/plain), 1.50 KB, created by Xavier Claessens on 2012-05-22 05:57:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Xavier Claessens

Created: 2012-05-22 05:57:29 UTC

Size: 1.50 KB

patch

obsolete

>From 7ae4bb07abec65796ea66c91a42080361200fb6d Mon Sep 17 00:00:00 2001
>From: Xavier Claessens <xavier.claessens@collabora.co.uk>
>Date: Wed, 16 May 2012 14:37:29 +0200
>Subject: [PATCH] tests/lib: Stop using tp_connection_new()
>
>https://bugs.freedesktop.org/show_bug.cgi?id=49372
>---
> tests/lib/util.c |    7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
>diff --git a/tests/lib/util.c b/tests/lib/util.c
>index fea462f..27f3180 100644
>--- a/tests/lib/util.c
>+++ b/tests/lib/util.c
>@@ -183,6 +183,7 @@ tp_tests_create_conn (GType conn_type,
>     TpConnection **client_conn)
> {
>   TpDBusDaemon *dbus;
>+  TpSimpleClientFactory *factory;
>   gchar *name;
>   gchar *conn_path;
>   GError *error = NULL;
>@@ -191,6 +192,7 @@ tp_tests_create_conn (GType conn_type,
>   g_assert (client_conn != NULL);
> 
>   dbus = tp_tests_dbus_daemon_dup_or_die ();
>+  factory = (TpSimpleClientFactory *) tp_automatic_client_factory_new (dbus);
> 
>   *service_conn = tp_tests_object_new_static_class (
>         conn_type,
>@@ -203,8 +205,8 @@ tp_tests_create_conn (GType conn_type,
>         &name, &conn_path, &error));
>   g_assert_no_error (error);
> 
>-  *client_conn = tp_connection_new (dbus, name, conn_path,
>-      &error);
>+  *client_conn = tp_simple_client_factory_ensure_connection (factory,
>+      conn_path, NULL, &error);;
>   g_assert (*client_conn != NULL);
>   g_assert_no_error (error);
> 
>@@ -220,6 +222,7 @@ tp_tests_create_conn (GType conn_type,
>   g_free (conn_path);
> 
>   g_object_unref (dbus);
>+  g_object_unref (factory);
> }
> 
> void
>-- 
>1.7.9.5

Actions: View | Splinter Review

Attachments on bug 49372: 61954 | 61955 | 61956 | 61957 | 61958 | 61959

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.