Attachment 46950 Details for Bug 36495 – Suggested patch

[patch] Suggested patch

36495.diff (text/plain), 985 bytes, created by Don't use this account, use tml@iki.fi on 2011-05-20 06:12:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Don't use this account, use tml@iki.fi

Created: 2011-05-20 06:12:01 UTC

Size: 985 bytes

patch

obsolete

>diff --git a/desktop/source/deployment/gui/dp_gui_updatedialog.cxx b/desktop/source/deployment/gui/dp_gui_updatedialog.cxx
>index 8b73e6b..7040822 100644
>--- a/desktop/source/deployment/gui/dp_gui_updatedialog.cxx
>+++ b/desktop/source/deployment/gui/dp_gui_updatedialog.cxx
>@@ -1263,11 +1263,15 @@ IMPL_LINK(UpdateDialog, selectionHandler, void *, EMPTYARG)
>             }
>             case DISABLED_UPDATE:
>             {
>-                bInserted = showDescription( m_disabledUpdates[pos].aUpdateInfo );
>+                if ( !m_disabledUpdates.empty() )
>+                    bInserted = showDescription( m_disabledUpdates[pos].aUpdateInfo );
> 
>                 if ( p->m_bIgnored )
>                     b.append( m_ignoredUpdate );
> 
>+                if ( m_disabledUpdates.empty() )
>+                    break;
>+
>                 UpdateDialog::DisabledUpdate & data = m_disabledUpdates[ pos ];
>                 if (data.unsatisfiedDependencies.getLength() != 0)
>                 {

Actions: View | Splinter Review

Attachments on bug 36495: 46517 | 46521 | 46556 | 46950

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.