Attachment 44319 Details for Bug 35182 – [PATCH 2/4] _dbus_marshal_write_fixed_multi: remove obsolete FIXME comment

[patch] [PATCH 2/4] _dbus_marshal_write_fixed_multi: remove obsolete FIXME comment

0002-_dbus_marshal_write_fixed_multi-remove-obsolete-FIXM.patch (text/plain), 1.12 KB, created by Simon McVittie on 2011-03-10 10:57:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2011-03-10 10:57:13 UTC

Size: 1.12 KB

patch

obsolete

>From 028b2b28094ab2cc9c969bab3f54ad1016e1b815 Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Thu, 3 Mar 2011 16:55:55 +0000
>Subject: [PATCH 2/4] _dbus_marshal_write_fixed_multi: remove obsolete FIXME comment
>
>As far as I can tell, we've never accepted out-of-range booleans and
>canonicalized them, ever since this was first committed in 2004. If sent,
>they'd be considered to be invalid by recipients, so they're unambiguously
>an error.
>---
> dbus/dbus-marshal-basic.c |    2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
>diff --git a/dbus/dbus-marshal-basic.c b/dbus/dbus-marshal-basic.c
>index ea18dbf..3cbc721 100644
>--- a/dbus/dbus-marshal-basic.c
>+++ b/dbus/dbus-marshal-basic.c
>@@ -1065,8 +1065,6 @@ _dbus_marshal_write_fixed_multi (DBusString *str,
>     case DBUS_TYPE_INT16:
>     case DBUS_TYPE_UINT16:
>       return marshal_fixed_multi (str, insert_at, vp, n_elements, byte_order, 2, pos_after);
>-      /* FIXME: we canonicalize to 0 or 1 for the single boolean case
>-       * should we here too ? */
>     case DBUS_TYPE_BOOLEAN:
>     case DBUS_TYPE_INT32:
>     case DBUS_TYPE_UINT32:
>-- 
>1.7.4.1
>

Actions: View | Splinter Review

Attachments on bug 35182: 44318 | 44319 | 44320 | 44321

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.