Attachment 44318 Details for Bug 35182 – [PATCH 1/4] dbus_message_iter_append_basic: remove misleading documentation

[patch] [PATCH 1/4] dbus_message_iter_append_basic: remove misleading documentation

0001-dbus_message_iter_append_basic-remove-misleading-doc.patch (text/plain), 1.06 KB, created by Simon McVittie on 2011-03-10 10:56:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2011-03-10 10:56:53 UTC

Size: 1.06 KB

patch

obsolete

>From ae3eff1799ff65e9ad5e4811525360d0c3cb6f4d Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Thu, 3 Mar 2011 16:30:43 +0000
>Subject: [PATCH 1/4] dbus_message_iter_append_basic: remove misleading documentation
>
>This function specifically doesn't support Unix fds and is documented as
>such.
>---
> dbus/dbus-message.c |    4 ----
> 1 files changed, 0 insertions(+), 4 deletions(-)
>
>diff --git a/dbus/dbus-message.c b/dbus/dbus-message.c
>index 442ec2a..7f57b96 100644
>--- a/dbus/dbus-message.c
>+++ b/dbus/dbus-message.c
>@@ -2598,10 +2598,6 @@ dbus_message_iter_append_basic (DBusMessageIter *iter,
>  * @todo If this fails due to lack of memory, the message is hosed and
>  * you have to start over building the whole message.
>  *
>- * For Unix file descriptors this function will internally duplicate
>- * the descriptor you passed in. Hence you may close the descriptor
>- * immediately after this call.
>- *
>  * @param iter the append iterator
>  * @param element_type the type of the array elements
>  * @param value the address of the array
>-- 
>1.7.4.1
>

Actions: View | Splinter Review

Attachments on bug 35182: 44318 | 44319 | 44320 | 44321

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.