Attachment 43154 Details for Bug 34030 – Possible Fix

[patch] Possible Fix

0001-r300-compiler-Don-t-erase-sources-from-readers-when-.patch (text/plain), 1.20 KB, created by Tom Stellard on 2011-02-09 01:46:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tom Stellard

Created: 2011-02-09 01:46:08 UTC

Size: 1.20 KB

patch

obsolete

>From 3f0f8451b4aaf6fdb575ee7754958b387be1e2f4 Mon Sep 17 00:00:00 2001
>From: Tom Stellard <tstellar@gmail.com>
>Date: Wed, 9 Feb 2011 01:43:29 -0800
>Subject: [PATCH] r300/compiler: Don't erase sources from readers when converting
> RGB->Alpha
>
>---
> .../dri/r300/compiler/radeon_pair_schedule.c       |    6 ------
> 1 files changed, 0 insertions(+), 6 deletions(-)
>
>diff --git a/src/mesa/drivers/dri/r300/compiler/radeon_pair_schedule.c b/src/mesa/drivers/dri/r300/compiler/radeon_pair_schedule.c
>index dd26049..8e10813 100644
>--- a/src/mesa/drivers/dri/r300/compiler/radeon_pair_schedule.c
>+++ b/src/mesa/drivers/dri/r300/compiler/radeon_pair_schedule.c
>@@ -544,18 +544,12 @@ static void rgb_to_alpha_remap (
> {
> 	int new_src_index;
> 	unsigned int i;
>-	struct rc_pair_instruction_source * old_src =
>-					rc_pair_get_src(&inst->U.P, arg);
>-	if (!old_src) {
>-		return;
>-	}
> 
> 	for (i = 0; i < 3; i++) {
> 		if (get_swz(arg->Swizzle, i) == old_swz) {
> 			SET_SWZ(arg->Swizzle, i, RC_SWIZZLE_W);
> 		}
> 	}
>-	memset(old_src, 0, sizeof(struct rc_pair_instruction_source));
> 	new_src_index = rc_pair_alloc_source(&inst->U.P, 0, 1,
> 							old_file, new_index);
> 	/* This conversion is not possible, we must have made a mistake in
>-- 
>1.7.2.5
>

Actions: View | Splinter Review

Attachments on bug 34030: 43092 | 43093 | 43151 | 43152 | 43154

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.