Attachment 42259 Details for Bug 33318 – Proposed fix

[patch] Proposed fix

0001-win32-Do-not-clip_fini-uninitialized-clips.patch (text/plain), 1.21 KB, created by Andrea Canciani on 2011-01-21 01:48:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andrea Canciani

Created: 2011-01-21 01:48:41 UTC

Size: 1.21 KB

patch

obsolete

>From ab58fd873512a28091657eca7b12f9d957f561ad Mon Sep 17 00:00:00 2001
>From: Andrea Canciani <ranma42@gmail.com>
>Date: Fri, 21 Jan 2011 10:43:49 +0100
>Subject: [PATCH] win32: Do not clip_fini uninitialized clips
>
>TODO: explain when it can happen, add a testcase which gets fixed by
>this.
>
>See https://bugs.freedesktop.org/show_bug.cgi?id=33318
>---
> src/cairo-gstate.c |    4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/src/cairo-gstate.c b/src/cairo-gstate.c
>index efb8267..9f9d0ef 100644
>--- a/src/cairo-gstate.c
>+++ b/src/cairo-gstate.c
>@@ -2005,6 +2005,7 @@ _cairo_gstate_show_text_glyphs (cairo_gstate_t		   *gstate,
> 						  cluster_flags,
> 						  gstate->scaled_font,
> 						  _gstate_get_clip (gstate, &clip));
>+	_cairo_clip_fini (&clip);
>     }
>     else
>     {
>@@ -2023,13 +2024,12 @@ _cairo_gstate_show_text_glyphs (cairo_gstate_t		   *gstate,
> 					  gstate->tolerance,
> 					  gstate->scaled_font->options.antialias,
> 					  _gstate_get_clip (gstate, &clip));
>+	    _cairo_clip_fini (&clip);
> 	}
> 
> 	_cairo_path_fixed_fini (&path);
>     }
> 
>-    _cairo_clip_fini (&clip);
>-
> CLEANUP_GLYPHS:
>     if (transformed_glyphs != stack_transformed_glyphs)
>       cairo_glyph_free (transformed_glyphs);
>-- 
>1.7.1
>

Actions: View | Splinter Review

Attachments on bug 33318: 42259

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.