Attachment 38518 Details for Bug 29774 – call notify_invalid_framebuffer after swapping

[patch] call notify_invalid_framebuffer after swapping

0001-st-xlib-Notify-the-context-when-the-front-back-buffe.patch (text/plain), 2.80 KB, created by Chia-I Wu on 2010-09-07 10:10:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chia-I Wu

Created: 2010-09-07 10:10:59 UTC

Size: 2.80 KB

patch

obsolete

>From c6626fbc0b46ddafb492c166d1bdf73ff95fe73b Mon Sep 17 00:00:00 2001
>From: Chia-I Wu <olv@lunarg.com>
>Date: Wed, 8 Sep 2010 00:30:27 +0800
>Subject: [PATCH] st/xlib: Notify the context when the front/back buffers are swapped.
>
>The current context should be notified when the the front/back buffers
>of the current drawable are swapped.  The notification was skipped when
>xmesa_strict_invalidate is false (the default).
>---
> src/gallium/state_trackers/glx/xlib/xm_api.c |   18 ++++++++++++++----
> src/gallium/state_trackers/glx/xlib/xm_api.h |    3 +++
> src/gallium/state_trackers/glx/xlib/xm_st.c  |    4 ++++
> 3 files changed, 21 insertions(+), 4 deletions(-)
>
>diff --git a/src/gallium/state_trackers/glx/xlib/xm_api.c b/src/gallium/state_trackers/glx/xlib/xm_api.c
>index eb4ce74..a9ba194 100644
>--- a/src/gallium/state_trackers/glx/xlib/xm_api.c
>+++ b/src/gallium/state_trackers/glx/xlib/xm_api.c
>@@ -1082,19 +1082,29 @@ XMesaDestroyBuffer(XMesaBuffer b)
> 
> 
> /**
>- * Query the current drawable size and notify the binding context.
>+ * Notify the binding context to validate the buffer.
>  */
> void
>-xmesa_check_buffer_size(XMesaBuffer b)
>+xmesa_notify_invalid_buffer(XMesaBuffer b)
> {
>    XMesaContext xmctx = XMesaGetCurrentContext();
> 
>+   if (xmctx && xmctx->xm_buffer == b)
>+      xmctx->st->notify_invalid_framebuffer(xmctx->st, b->stfb);
>+}
>+
>+
>+/**
>+ * Query the current drawable size and notify the binding context.
>+ */
>+void
>+xmesa_check_buffer_size(XMesaBuffer b)
>+{
>    if (b->type == PBUFFER)
>       return;
> 
>    xmesa_get_window_size(b->xm_visual->display, b, &b->width, &b->height);
>-   if (xmctx && xmctx->xm_buffer == b)
>-      xmctx->st->notify_invalid_framebuffer(xmctx->st, b->stfb);
>+   xmesa_notify_invalid_buffer(b);
> }
> 
> 
>diff --git a/src/gallium/state_trackers/glx/xlib/xm_api.h b/src/gallium/state_trackers/glx/xlib/xm_api.h
>index f209b14..fedf2b2 100644
>--- a/src/gallium/state_trackers/glx/xlib/xm_api.h
>+++ b/src/gallium/state_trackers/glx/xlib/xm_api.h
>@@ -361,6 +361,9 @@ xmesa_get_window_size(Display *dpy, XMesaBuffer b,
>                       GLuint *width, GLuint *height);
> 
> extern void
>+xmesa_notify_invalid_buffer(XMesaBuffer b);
>+
>+extern void
> xmesa_check_buffer_size(XMesaBuffer b);
> 
> extern void
>diff --git a/src/gallium/state_trackers/glx/xlib/xm_st.c b/src/gallium/state_trackers/glx/xlib/xm_st.c
>index 4c0ce07..4d0f5e6 100644
>--- a/src/gallium/state_trackers/glx/xlib/xm_st.c
>+++ b/src/gallium/state_trackers/glx/xlib/xm_st.c
>@@ -339,6 +339,10 @@ xmesa_swap_st_framebuffer(struct st_framebuffer_iface *stfbi)
>          tmp = *front;
>          *front = *back;
>          *back = tmp;
>+
>+         /* the current context should validate the buffer after swapping */
>+         if (!xmesa_strict_invalidate)
>+            xmesa_notify_invalid_buffer(xstfb->buffer);
>       }
> 
>       if (xmesa_strict_invalidate)
>-- 
>1.7.1
>

Actions: View | Splinter Review

Attachments on bug 29774: 38390 | 38518

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.