Attachment 27131 Details for Bug 22472 – Patch to raise XV limit to match hardware limit

[patch] Patch to raise XV limit to match hardware limit

0001-Raise-XV-limit-to-2048x2048-to-match-hardware-limits.patch (text/plain), 1.84 KB, created by Barry Scott on 2009-06-25 06:19:11 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Barry Scott

Created: 2009-06-25 06:19:11 UTC

Size: 1.84 KB

patch

obsolete

>>From 7b3f0ef4dbf4e0bb6d51c8c548d70509be56ab37 Mon Sep 17 00:00:00 2001
>From: Simon Farnsworth <simon.farnsworth@onelan.co.uk>
>Date: Thu, 18 Jun 2009 12:33:47 +0100
>Subject: [PATCH] Raise XV limit to 2048x2048 to match hardware limits.
>
>The bigrequests limit isn't present in current X servers (tested using
>textured video on a 965 with both image and window at 2048x2048 on a
>1920x1200 display, and image at 2048x2048, window at 1024x1024).
>
>Remove the artificial limit, enabling full-screen HD video when
>rotated.
>---
> src/i830_video.c |   16 ++++------------
> 1 files changed, 4 insertions(+), 12 deletions(-)
>
>diff --git a/src/i830_video.c b/src/i830_video.c
>index 28b761f..3ca20ea 100644
>--- a/src/i830_video.c
>+++ b/src/i830_video.c
>@@ -114,19 +114,11 @@ static Atom xvSyncToVblank;
> 
> /* Limits for the overlay/textured video source sizes.  The documented hardware
>  * limits are 2048x2048 or better for overlay and both of our textured video
>- * implementations.  However, we run into the bigrequests limit of (currently)
>- * 4MB, which even the planar format's 2048*2048*1.5 bytes is larger than.
>- * Conveniently, the HD resolution, even in packed format, takes
>- * (1920*1088*2) bytes, which is just shy of 4MB.  Additionally, on the 830
>- * and 845, larger sizes resulted in the card hanging, so we keep the limits
>- * lower there.
>- *
>- * While the HD resolution is actually 1920x1080, we increase our advertised
>- * size to 1088 because some software wants to send an image aligned to
>- * 16-pixel boundaries.
>+ * implementations.  Additionally, on the 830 and 845, larger sizes resulted in
>+ * the card hanging, so we keep the limits lower there.
>  */
>-#define IMAGE_MAX_WIDTH		1920
>-#define IMAGE_MAX_HEIGHT	1088
>+#define IMAGE_MAX_WIDTH		2048
>+#define IMAGE_MAX_HEIGHT	2048
> #define IMAGE_MAX_WIDTH_LEGACY	1024
> #define IMAGE_MAX_HEIGHT_LEGACY	1088
> 
>-- 
>1.5.4.1
>

Actions: View | Splinter Review

Attachments on bug 22472: 27131

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.