Attachment 19433 Details for Bug 17943 – patch to avoid gcc warnings and comment about freetype2 ALPHA code

[patch] patch to avoid gcc warnings and comment about freetype2 ALPHA code

patch-01-ftsynth (text/plain), 1.08 KB, created by Peter Breitenlohner on 2008-10-07 04:25:25 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Peter Breitenlohner

Created: 2008-10-07 04:25:25 UTC

Size: 1.08 KB

patch

obsolete

>	This patch avoids the two gcc warnings
>		../../libXft-2.1.13/src/xftglyphs.c:174: warning: implicit declaration of function `FT_GlyphSlot_Embolden'
>		../../libXft-2.1.13/src/xftglyphs.c:174: warning: nested extern declaration of `FT_GlyphSlot_Embolden'
>
>	However, quoting from ftsynth.h (freetype2-2.3.7)
>	        WARNING, THIS IS ALPHA CODE, THIS API
>	    IS DUE TO CHANGE UNTIL STRICTLY NOTIFIED BY THE
>	            FREETYPE DEVELOPMENT TEAM
>	and just before the declaration of FT_GlyphSlot_Embolden
>	  /* Do not use this function directly!  Copy the code to */
>	  /* your application and modify it to suit your need.    */
>
>	Conclusion: Shouldn't one just do that (i.e., copy the code)?
>
>diff -ur libXft-2.1.13.orig/src/xftglyphs.c libXft-2.1.13/src/xftglyphs.c
>--- libXft-2.1.13.orig/src/xftglyphs.c	2008-05-12 23:31:03.000000000 +0200
>+++ libXft-2.1.13/src/xftglyphs.c	2008-10-07 13:04:57.000000000 +0200
>@@ -22,6 +22,9 @@
> 
> #include "xftint.h"
> #include <freetype/ftoutln.h>
>+#if HAVE_FT_GLYPHSLOT_EMBOLDEN
>+#include <freetype/ftsynth.h>
>+#endif
> 
> static const int    filters[3][3] = {
>     /* red */

Actions: View | Splinter Review

Attachments on bug 17943: 19433

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.