Attachment 19109 Details for Bug 17310 – Use LFP data pointers instead of array

[patch] Use LFP data pointers instead of array

i830-use-lfp-data-ptrs.patch (text/plain), 2.60 KB, created by Jesse Barnes on 2008-09-22 17:49:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jesse Barnes

Created: 2008-09-22 17:49:23 UTC

Size: 2.60 KB

patch

obsolete

>diff --git a/src/bios_reader/bios_reader.c b/src/bios_reader/bios_reader.c
>index 9e05317..3680a73 100644
>--- a/src/bios_reader/bios_reader.c
>+++ b/src/bios_reader/bios_reader.c
>@@ -180,6 +180,19 @@ static void dump_lvds_options(void *data)
>     printf("\tPFIT mode: %d\n", options->pfit_mode);
> }
> 
>+static void dump_lvds_ptr_data(void *data, unsigned char *base)
>+{
>+    struct bdb_lvds_lfp_data_ptrs *ptrs = data;
>+
>+    struct lvds_fp_timing *fp_timing =
>+	(struct lvds_fp_timing *)(base + ptrs->ptr[panel_type].fp_timing_offset);
>+
>+    printf("LVDS timing pointer data:\n");
>+
>+    printf("\tpanel type %02i: %dx%d\n", panel_type, fp_timing->x_res,
>+	   fp_timing->y_res);
>+}
>+
> static void dump_lvds_data(void *data, unsigned char *base)
> {
>     struct bdb_lvds_lfp_data *lvds_data = data;
>@@ -198,7 +211,7 @@ static void dump_lvds_data(void *data, unsigned char *base)
> 	if (i == panel_type)
> 	    marker = '*';
> 	else
>-	    continue;
>+	    marker = ' ';
> 
> 	printf("%c\tpanel type %02i: %dx%d clock %d\n", marker,
> 	       i, lfp_data->fp_timing.x_res, lfp_data->fp_timing.y_res,
>@@ -285,6 +298,8 @@ int main(int argc, char **argv)
>     dump_general_definitions(find_section(bdb, BDB_GENERAL_DEFINITIONS));
>     dump_lvds_options(find_section(bdb, BDB_LVDS_OPTIONS));
>     dump_lvds_data(find_section(bdb, BDB_LVDS_LFP_DATA), (unsigned char *)bdb);
>+    dump_lvds_ptr_data(find_section(bdb, BDB_LVDS_LFP_DATA_PTRS),
>+		       (unsigned char *)bdb);
> 
>     return 0;
> }
>diff --git a/src/i830_bios.c b/src/i830_bios.c
>index ff49025..2cb0b07 100644
>--- a/src/i830_bios.c
>+++ b/src/i830_bios.c
>@@ -88,8 +88,8 @@ static void
> parse_panel_data(I830Ptr pI830, struct bdb_header *bdb)
> {
>     struct bdb_lvds_options *lvds_options;
>-    struct bdb_lvds_lfp_data *lvds_lfp_data;
>-    struct bdb_lvds_lfp_data_entry *entry;
>+    struct bdb_lvds_lfp_data_ptrs *lvds_lfp_data_ptrs;
>+    int timing_offset;
>     DisplayModePtr fixed_mode;
>     unsigned char *timing_ptr;
> 
>@@ -104,12 +104,13 @@ parse_panel_data(I830Ptr pI830, struct bdb_header *bdb)
>     if (lvds_options->panel_type == 0xff)
> 	return;
> 
>-    lvds_lfp_data = find_section(bdb, BDB_LVDS_LFP_DATA);
>-    if (!lvds_lfp_data)
>+    lvds_lfp_data_ptrs = find_section(bdb, BDB_LVDS_LFP_DATA_PTRS);
>+    if (!lvds_lfp_data_ptrs)
> 	return;
> 
>-    entry = &lvds_lfp_data->data[lvds_options->panel_type];
>-    timing_ptr = (unsigned char *)&entry->dvo_timing;
>+    timing_offset =
>+	lvds_lfp_data_ptrs->ptr[lvds_options->panel_type].dvo_timing_offset;
>+    timing_ptr = (unsigned char *)bdb + timing_offset;
> 
>     fixed_mode = xnfalloc(sizeof(DisplayModeRec));
>     memset(fixed_mode, 0, sizeof(*fixed_mode));

Actions: View | Splinter Review

Attachments on bug 17310: 18524 | 18526 | 18527 | 18536 | 19109 | 19124

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.