Attachment 15171 Details for Bug 14736 – 0002-Compile-warning-fixes.patch

[patch] 0002-Compile-warning-fixes.patch

0002-Compile-warning-fixes.patch (text/plain), 1.52 KB, created by Paulo César Pereira de Andrade on 2008-03-15 22:31:42 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Paulo César Pereira de Andrade

Created: 2008-03-15 22:31:42 UTC

Size: 1.52 KB

patch

obsolete

>From a8bb7d59ef0ee9874e37ea9676eabeb6511f247f Mon Sep 17 00:00:00 2001
>From: Paulo Cesar Pereira de Andrade <pcpa@mandriva.com.br>
>Date: Sun, 16 Mar 2008 02:28:16 -0300
>Subject: [PATCH] Compile warning fixes.
>
>  Ansify a function with K&R style definition.
>  Obey gcc in warning suggest parentheses around assignment used as truth value.
>  Remove some unused variables.
>  Remaining warning is about xf86AddModuleInfo being deprecated.
>---
> src/mouse.c |    6 ++----
> src/pnp.c   |    5 +----
> 2 files changed, 3 insertions(+), 8 deletions(-)
>
>diff --git a/src/mouse.c b/src/mouse.c
>index ce29f32..4f9a1b4 100644
>--- a/src/mouse.c
>+++ b/src/mouse.c
>@@ -802,8 +802,8 @@ MouseHWOptions(InputInfoPtr pInfo)
> 		pMse->resolution);
>     }
> 
>-    if (mPriv->sensitivity 
>-	= xf86SetRealOption(pInfo->options, "Sensitivity", 1.0)) {
>+    if ((mPriv->sensitivity 
>+	 = xf86SetRealOption(pInfo->options, "Sensitivity", 1.0))) {
> 	xf86Msg(X_CONFIG, "%s: Sensitivity: %g\n", pInfo->name,
> 		mPriv->sensitivity);
>     }
>@@ -1860,8 +1860,6 @@ MouseConvert(InputInfoPtr pInfo, int first, int num, int v0, int v1, int v2,
> static void
> FlushButtons(MouseDevPtr pMse)
> {
>-    int i, blocked;
>-
>     pMse->lastButtons = 0;
>     pMse->lastMappedButtons = 0;
> }
>diff --git a/src/pnp.c b/src/pnp.c
>index edbc694..7ae13f2 100644
>--- a/src/pnp.c
>+++ b/src/pnp.c
>@@ -551,10 +551,7 @@ pnpproto(pnpid_t *id)
> /* name/val mapping */
> 
> static symtab_t *
>-gettoken(tab, s, len)
>-symtab_t *tab;
>-char *s;
>-int len;
>+gettoken(symtab_t *tab, char *s, int len)
> {
>     int i;
> 
>-- 
>1.5.3.2
>

Actions: View | Splinter Review

Attachments on bug 14736: 14696 | 15171

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.