Attachment 141619 Details for Bug 107899 – DRM syncobj fence leak fix

[patch] DRM syncobj fence leak fix

0001-drm-syncobj-Don-t-leak-fences-when-WAIT_FOR_SUBMIT-i.patch (text/plain), 1.28 KB, created by Jason Ekstrand on 2018-09-18 08:16:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jason Ekstrand

Created: 2018-09-18 08:16:01 UTC

Size: 1.28 KB

patch

obsolete

>From d76e8cae747b144ec7804ad513f9645fa01380ec Mon Sep 17 00:00:00 2001
>From: Jason Ekstrand <jason.ekstrand@intel.com>
>Date: Tue, 18 Sep 2018 02:26:46 -0500
>Subject: [PATCH] drm/syncobj: Don't leak fences when WAIT_FOR_SUBMIT is set
>
>We attempt to get fences earlier in the hopes that everything will
>already have fences and no callbacks will be needed.  If we do succeed
>in getting a fence, getting one a second time will result in a duplicate
>ref with no unref.
>---
> drivers/gpu/drm/drm_syncobj.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
>diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c
>index adb3cb27d31e..759278fef35a 100644
>--- a/drivers/gpu/drm/drm_syncobj.c
>+++ b/drivers/gpu/drm/drm_syncobj.c
>@@ -97,6 +97,8 @@ static int drm_syncobj_fence_get_or_add_callback(struct drm_syncobj *syncobj,
> {
> 	int ret;
> 
>+	WARN_ON(*fence);
>+
> 	*fence = drm_syncobj_fence_get(syncobj);
> 	if (*fence)
> 		return 1;
>@@ -743,6 +745,9 @@ static signed long drm_syncobj_array_wait_timeout(struct drm_syncobj **syncobjs,
> 
> 	if (flags & DRM_SYNCOBJ_WAIT_FLAGS_WAIT_FOR_SUBMIT) {
> 		for (i = 0; i < count; ++i) {
>+			if (entries[i].fence)
>+				continue;
>+
> 			drm_syncobj_fence_get_or_add_callback(syncobjs[i],
> 							      &entries[i].fence,
> 							      &entries[i].syncobj_cb,
>-- 
>2.17.1
>

Actions: View | Splinter Review

Attachments on bug 107899: 141521 | 141589 | 141590 | 141603 | 141619 | 141641

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.