Attachment 141395 Details for Bug 105330 – Set a DBusError in all failing paths of bus_selinux_check()

[patch] Set a DBusError in all failing paths of bus_selinux_check()

Set-a-DBusError-in-all-failing-paths-of-busselinux.patch (text/plain), 1.34 KB, created by Laurent Bigonville on 2018-08-31 10:53:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Laurent Bigonville

Created: 2018-08-31 10:53:19 UTC

Size: 1.34 KB

patch

obsolete

>From ea243223446d47dd5bfaffbbbd4c2762310609b8 Mon Sep 17 00:00:00 2001
>From: Laurent Bigonville <bigon@bigon.be>
>Date: Fri, 31 Aug 2018 12:49:39 +0200
>Subject: [PATCH] Set a DBusError in all failing paths of bus_selinux_check()
>
>https://bugs.freedesktop.org/show_bug.cgi?id=105330
>---
> bus/selinux.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
>diff --git a/bus/selinux.c b/bus/selinux.c
>index 4db9b8ac..614495f6 100644
>--- a/bus/selinux.c
>+++ b/bus/selinux.c
>@@ -421,13 +421,16 @@ bus_selinux_check (BusSELinuxID        *sender_sid,
>     switch (errno)
>       {
>       case EACCES:
>-        _dbus_verbose ("SELinux denying due to security policy.\n");
>+        dbus_set_error (error, DBUS_ERROR_ACCESS_DENIED,
>+                        "SELinux denying due to security policy.");
>         return FALSE;
>       case EINVAL:
>-        _dbus_verbose ("SELinux denying due to invalid security context.\n");
>+        dbus_set_error (error, DBUS_ERROR_ACCESS_DENIED,
>+                        "SELinux denying due to invalid security context.");
>         return FALSE;
>       default:
>-        _dbus_verbose ("SELinux denying due to: %s\n", _dbus_strerror (errno));
>+        dbus_set_error (error, DBUS_ERROR_ACCESS_DENIED,
>+                        "SELinux denying due to: %s", _dbus_strerror (errno));
>         return FALSE;
>       }
>     }
>-- 
>2.19.0.rc1

Actions: View | Splinter Review

Attachments on bug 105330: 137821 | 138021 | 141393 | 141394 | 141395

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.