Attachment 138992 Details for Bug 106183 – The said patch

[patch] The said patch

0001-Fix-is_valid_section_name-always-returning-true.patch (text/plain), 1.23 KB, created by Albert Astals Cid on 2018-04-23 07:08:17 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Albert Astals Cid

Created: 2018-04-23 07:08:17 UTC

Size: 1.23 KB

patch

obsolete

>From 1564036166a316a4fd6160720f2487325ea0bce3 Mon Sep 17 00:00:00 2001
>From: Albert Astals Cid <albert.astals.cid@kdab.com>
>Date: Mon, 23 Apr 2018 09:06:20 +0200
>Subject: [PATCH] Fix is_valid_section_name always returning true
>
>The if condition was
>
>if (!((*name >= 'A' && *name <= 'Z') || (*name >= 'a' || *name <= 'z') ||
>	    *name == '\n' || *name == '\t'))
>
>which translates to
>
>if ((!(*name >= 'A' && *name <= 'Z') && !(*name >= 'a' || *name <= 'z') &&
>	    *name != '\n' && *name != '\t'))
>
>which translates to
>
>if (((*name < 'A' || *name > 'Z') && (*name < 'a' && *name > 'z') &&
>	    *name != '\n' && *name != '\t'))
>
>which will always be false since name can't be both smaller than a and bigger than z
>
>Found by gcc
>---
> bus/desktop-file.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/bus/desktop-file.c b/bus/desktop-file.c
>index c824d566..2f41359a 100644
>--- a/bus/desktop-file.c
>+++ b/bus/desktop-file.c
>@@ -382,7 +382,7 @@ is_valid_section_name (const char *name)
> 
>   while (*name)
>     {
>-      if (!((*name >= 'A' && *name <= 'Z') || (*name >= 'a' || *name <= 'z') ||
>+      if (!((*name >= 'A' && *name <= 'Z') || (*name >= 'a' && *name <= 'z') ||
> 	    *name == '\n' || *name == '\t'))
> 	return FALSE;
>       
>-- 
>2.17.0
>

Actions: View | Splinter Review

Attachments on bug 106183: 138992

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.