Attachment 138224 Details for Bug 105625 – [PATCH 2/2] linux: Check "HasBattery" key for newer iOS versions

[patch] [PATCH 2/2] linux: Check "HasBattery" key for newer iOS versions

0002-linux-Check-HasBattery-key-for-newer-iOS-versions.patch (text/plain), 1.47 KB, created by Martin S. on 2018-03-20 14:13:22 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin S.

Created: 2018-03-20 14:13:22 UTC

Size: 1.47 KB

patch

obsolete

>From 4495fc0612b25b1a9a7957969d21c3bf875c4696 Mon Sep 17 00:00:00 2001
>From: Martin Szulecki <martin.szulecki@libimobiledevice.org>
>Date: Tue, 20 Mar 2018 15:04:26 +0100
>Subject: [PATCH 2/2] linux: Check "HasBattery" key for newer iOS versions
>
>This adds an extra check to query if the iOS device has a
>battery at all before actually trying to retrieve the battery
>status. Should still work for older iOS versions which do not
>provide this key.
>
>https://bugzilla.freedesktop.org/show_bug.cgi?id=105625
>---
> src/linux/up-device-idevice.c | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
>diff --git a/src/linux/up-device-idevice.c b/src/linux/up-device-idevice.c
>index a583881..0c404cc 100644
>--- a/src/linux/up-device-idevice.c
>+++ b/src/linux/up-device-idevice.c
>@@ -269,7 +269,7 @@ up_device_idevice_refresh (UpDevice *device)
> 	lockdownd_client_t client = NULL;
> 	plist_t dict, node;
> 	guint64 percentage;
>-	guint8 charging;
>+	guint8 charging, has_battery;
> 	UpDeviceState state;
> 	gboolean retval = FALSE;
> 
>@@ -284,6 +284,15 @@ up_device_idevice_refresh (UpDevice *device)
> 	if (lockdownd_get_value (client, "com.apple.mobile.battery", NULL, &dict) != LOCKDOWN_E_SUCCESS)
> 		goto out;
> 
>+	node = plist_dict_get_item (dict, "HasBattery");
>+	if (node) {
>+		plist_get_bool_val (node, &has_battery);
>+		if (!has_battery) {
>+			plist_free(dict);
>+			goto out;
>+		}
>+	}
>+
> 	/* get battery status */
> 	node = plist_dict_get_item (dict, "BatteryCurrentCapacity");
> 	if (!node) {
>-- 
>2.16.2
>

Actions: View | Splinter Review

Attachments on bug 105625: 138223 | 138224

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.