Attachment 138223 Details for Bug 105625 – [PATCH 1/2] linux: Prevent crash after attaching an Apple TV

[patch] [PATCH 1/2] linux: Prevent crash after attaching an Apple TV

0001-linux-Prevent-crash-after-attaching-an-Apple-TV.patch (text/plain), 1019 bytes, created by Martin S. on 2018-03-20 14:12:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin S.

Created: 2018-03-20 14:12:27 UTC

Size: 1019 bytes

patch

obsolete

>From b5c0c1af09211d16057fa15f49246b7bb6a69f68 Mon Sep 17 00:00:00 2001
>From: Martin Szulecki <martin.szulecki@libimobiledevice.org>
>Date: Tue, 20 Mar 2018 15:00:21 +0100
>Subject: [PATCH 1/2] linux: Prevent crash after attaching an Apple TV
>
>As Apple TVs do not have a battery and do not provide the
>"BatteryIsCharging" lockdown key, upower would crash due to a
>missing check whether the retrieved node is actually valid.
>
>https://bugzilla.freedesktop.org/show_bug.cgi?id=105625
>---
> src/linux/up-device-idevice.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/src/linux/up-device-idevice.c b/src/linux/up-device-idevice.c
>index 97d230c..a583881 100644
>--- a/src/linux/up-device-idevice.c
>+++ b/src/linux/up-device-idevice.c
>@@ -297,6 +297,10 @@ up_device_idevice_refresh (UpDevice *device)
> 
> 	/* get charging status */
> 	node = plist_dict_get_item (dict, "BatteryIsCharging");
>+	if (!node) {
>+		plist_free(dict);
>+		goto out;
>+	}
> 	plist_get_bool_val (node, &charging);
> 
> 	if (percentage == 100)
>-- 
>2.16.2
>

Actions: View | Splinter Review

Attachments on bug 105625: 138223 | 138224

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.