Attachment 136620 Details for Bug 103000 – This should fix the remaining regression

[patch] This should fix the remaining regression

xsync_comparison.patch (text/plain), 1003 bytes, created by David Weinehall on 2018-01-08 18:01:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Weinehall

Created: 2018-01-08 18:01:51 UTC

Size: 1003 bytes

patch

obsolete

>commit 8b98895e7de6060ec7c756502383218d430df751
>Author: David Weinehall <david.weinehall@linux.intel.com>
>Date:   Mon Jan 8 18:44:49 2018 +0200
>
>    sync: Fix diffgreater comparison
>    
>    While transitioning from CARD64 to int64,
>    the GreaterThan call was mistakenly been transformed into ">=".
>    Part of this was fixed already in
>    commit 8060196a3e80a3c0ad2c0abbe459416821cd366c
>    
>    This patch fixes the remaining issue.
>    
>    Signed-off-by: David Weinehall <david.weinehall@linux.intel.com>
>
>diff --git a/Xext/sync.c b/Xext/sync.c
>index 37d41f22410d..8f22a865bb35 100644
>--- a/Xext/sync.c
>+++ b/Xext/sync.c
>@@ -660,7 +660,7 @@ SyncAwaitTriggerFired(SyncTrigger * pTrigger)
>              */
>             if (overflow)
>                 continue;
>-            diffgreater = diff >= pAwait->event_threshold;
>+            diffgreater = diff > pAwait->event_threshold;
>             diffequal = diff == pAwait->event_threshold;
> 
>             /* "If the test-type is PositiveTransition or

Actions: View | Splinter Review

Attachments on bug 103000: 134493 | 136620

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.