Attachment 135101 Details for Bug 103480 – hopeful fix

[patch] hopeful fix

0001-i965-fix-blorp-stage_prog_data-param-leak.patch (text/plain), 2.05 KB, created by Tapani Pälli on 2017-10-27 12:06:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tapani Pälli

Created: 2017-10-27 12:06:51 UTC

Size: 2.05 KB

patch

obsolete

>From c75fb64508ccbe2666509b4f1d547a8d09aff84b Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Tapani=20P=C3=A4lli?= <tapani.palli@intel.com>
>Date: Fri, 27 Oct 2017 14:49:40 +0300
>Subject: [PATCH] i965: fix blorp stage_prog_data->param leak
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Patch uses mem_ctx for allocation to ensure param array gets freed
>later.
>
>==6164== 48 bytes in 1 blocks are definitely lost in loss record 61 of 193
>==6164==    at 0x4C2EB6B: malloc (vg_replace_malloc.c:299)
>==6164==    by 0x12E31C6C: ralloc_size (ralloc.c:121)
>==6164==    by 0x130189F1: fs_visitor::assign_constant_locations() (brw_fs.cpp:2095)
>==6164==    by 0x13022D32: fs_visitor::optimize() (brw_fs.cpp:5715)
>==6164==    by 0x13024D5A: fs_visitor::run_fs(bool, bool) (brw_fs.cpp:6229)
>==6164==    by 0x1302549A: brw_compile_fs (brw_fs.cpp:6570)
>==6164==    by 0x130C4B07: blorp_compile_fs (blorp.c:194)
>==6164==    by 0x130D384B: blorp_params_get_clear_kernel (blorp_clear.c:79)
>==6164==    by 0x130D3C56: blorp_fast_clear (blorp_clear.c:332)
>==6164==    by 0x12EFA439: do_single_blorp_clear (brw_blorp.c:1261)
>==6164==    by 0x12EFC4AF: brw_blorp_clear_color (brw_blorp.c:1326)
>==6164==    by 0x12EFF72B: brw_clear (brw_clear.c:297)
>
>Signed-off-by: Tapani PÃ¤lli <tapani.palli@intel.com>
>---
> src/intel/compiler/brw_fs.cpp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/src/intel/compiler/brw_fs.cpp b/src/intel/compiler/brw_fs.cpp
>index 4616529abc..6b27c38be7 100644
>--- a/src/intel/compiler/brw_fs.cpp
>+++ b/src/intel/compiler/brw_fs.cpp
>@@ -2092,7 +2092,7 @@ fs_visitor::assign_constant_locations()
>     */
>    uint32_t *param = stage_prog_data->param;
>    stage_prog_data->nr_params = num_push_constants;
>-   stage_prog_data->param = ralloc_array(NULL, uint32_t, num_push_constants);
>+   stage_prog_data->param = ralloc_array(mem_ctx, uint32_t, num_push_constants);
>    if (num_pull_constants > 0) {
>       stage_prog_data->nr_pull_params = num_pull_constants;
>       stage_prog_data->pull_param = ralloc_array(NULL, uint32_t,
>-- 
>2.13.6
>

Actions: View | Splinter Review

Attachments on bug 103480: 135100 | 135101

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.