Attachment 130687 Details for Bug 100568 – test: Fix a couple of memory leaks in test-corrupt

[patch] test: Fix a couple of memory leaks in test-corrupt

test-Fix-a-couple-of-memory-leaks-in-test-corrupt.patch (text/plain), 1.60 KB, created by Philip Withnall on 2017-04-05 10:36:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Philip Withnall

Created: 2017-04-05 10:36:44 UTC

Size: 1.60 KB

patch

obsolete

>From 1a3d00a79c05c588e5227d68bd51642d36fdcc67 Mon Sep 17 00:00:00 2001
>From: Philip Withnall <withnall@endlessm.com>
>Date: Wed, 5 Apr 2017 11:36:12 +0100
>Subject: [PATCH] test: Fix a couple of memory leaks in test-corrupt
>
>Spotted while testing bug #100568.
>
>Signed-off-by: Philip Withnall <withnall@endlessm.com>
>---
> test/corrupt.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
>diff --git a/test/corrupt.c b/test/corrupt.c
>index 56a0cdf..d6f8502 100644
>--- a/test/corrupt.c
>+++ b/test/corrupt.c
>@@ -99,14 +99,16 @@ test_connect (Fixture *f,
>     gconstpointer addr G_GNUC_UNUSED)
> {
>   dbus_bool_t have_mem;
>+  char *address = NULL;
> 
>   g_assert (f->server_conn == NULL);
> 
>-  f->client_conn = dbus_connection_open_private (
>-      dbus_server_get_address (f->server), &f->e);
>+  address = dbus_server_get_address (f->server);
>+  f->client_conn = dbus_connection_open_private (address, &f->e);
>   assert_no_error (&f->e);
>   g_assert (f->client_conn != NULL);
>   test_connection_setup (f->ctx, f->client_conn);
>+  dbus_free (address);
> 
>   while (f->server_conn == NULL)
>     {
>@@ -352,6 +354,7 @@ teardown (Fixture *f,
> {
>   if (f->client_conn != NULL)
>     {
>+      test_connection_shutdown (f->ctx, f->client_conn);
>       dbus_connection_close (f->client_conn);
>       dbus_connection_unref (f->client_conn);
>       f->client_conn = NULL;
>@@ -359,6 +362,7 @@ teardown (Fixture *f,
> 
>   if (f->server_conn != NULL)
>     {
>+      test_connection_shutdown (f->ctx, f->server_conn);
>       dbus_connection_close (f->server_conn);
>       dbus_connection_unref (f->server_conn);
>       f->server_conn = NULL;
>-- 
>2.9.3

Actions: View | Splinter Review

Attachments on bug 100568: 130686 | 130687

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.