Attachment 130429 Details for Bug 98191 – [6] dbus-monitor: handle default case for binary mode header

[patch] [6] dbus-monitor: handle default case for binary mode header

0006-dbus-monitor-handle-default-case-for-binary-mode-hea.patch (text/plain), 1.01 KB, created by Simon McVittie on 2017-03-24 19:43:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2017-03-24 19:43:35 UTC

Size: 1.01 KB

patch

obsolete

>From f4d8048364860d780082d2eaa555c7e7d12ced4b Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Tue, 17 Jan 2017 20:42:31 +0000
>Subject: [PATCH 06/16] dbus-monitor: handle default case for binary mode
> header
>
>Also comment why it's OK to not do anything for the modes that don't
>have a header. We are effectively treating the default case as one
>of those, on the assumption that future modes are more likely to
>lack a header than to have one.
>
>Based on part of a patch from Thomas Zimmermann.
>
>Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
>---
> tools/dbus-monitor.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/tools/dbus-monitor.c b/tools/dbus-monitor.c
>index 4edee29e..c6f36d59 100644
>--- a/tools/dbus-monitor.c
>+++ b/tools/dbus-monitor.c
>@@ -555,6 +555,8 @@ main (int argc, char *argv[])
>     {
>       case BINARY_MODE_NOT:
>       case BINARY_MODE_RAW:
>+      default:
>+        /* no special header needed */
>         break;
> 
>       case BINARY_MODE_PCAP:
>-- 
>2.11.0
>

Actions: View | Splinter Review

Attachments on bug 98191: 127281 | 127282 | 127283 | 127284 | 127285 | 127286 | 129005 | 130424 | 130425 | 130426 | 130427 | 130428 | 130429 | 130430 | 130431 | 130432 | 130433 | 130434 | 130435 | 130436 | 130437 | 130438 | 130439 | 130442 | 130743

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.