Attachment 129429 Details for Bug 99724 – test: Add a missing OOM path in manual-dir-iter test

[patch] test: Add a missing OOM path in manual-dir-iter test

test-Add-a-missing-OOM-path-in-manual-dir-iter-tes.patch (text/plain), 973 bytes, created by Philip Withnall on 2017-02-09 10:14:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Philip Withnall

Created: 2017-02-09 10:14:19 UTC

Size: 973 bytes

patch

obsolete

>From 9a948ddf3b28580db5f230764cbdc1e9f93fe721 Mon Sep 17 00:00:00 2001
>From: Philip Withnall <withnall@endlessm.com>
>Date: Thu, 9 Feb 2017 09:57:48 +0000
>Subject: [PATCH] test: Add a missing OOM path in manual-dir-iter test
>
>Odd that this one was missing but all the other ones were in place.
>
>Coverity ID: 54721
>
>Signed-off-by: Philip Withnall <withnall@endlessm.com>
>
>https://bugs.freedesktop.org/show_bug.cgi?id=99724
>---
> test/manual-dir-iter.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/test/manual-dir-iter.c b/test/manual-dir-iter.c
>index 21ac0e9..8508174 100644
>--- a/test/manual-dir-iter.c
>+++ b/test/manual-dir-iter.c
>@@ -47,7 +47,9 @@ main (int    argc,
>   if (!_dbus_string_init (&dirname))
>       oom ("init dirname");
> 
>-  _dbus_string_append (&dirname, argv[1]);
>+  if (!_dbus_string_append (&dirname, argv[1]))
>+      oom ("append argv[1]");
>+
>   dir = _dbus_directory_open (&dirname, &tmp_error);
> 
>   if (dir == NULL)
>-- 
>2.9.3

Actions: View | Splinter Review

Attachments on bug 99724: 129427 | 129428 | 129429 | 129430 | 129474 | 129475

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.