Attachment 129362 Details for Bug 99693 – tools: Improve argument validation in dbus-spam

[patch] tools: Improve argument validation in dbus-spam

tools-Improve-argument-validation-in-dbus-spam.patch (text/plain), 1.27 KB, created by Philip Withnall on 2017-02-06 13:03:45 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Philip Withnall

Created: 2017-02-06 13:03:45 UTC

Size: 1.27 KB

patch

obsolete

>From 0065962ab9f97fe0e145b7e62ae6ed610c85fad1 Mon Sep 17 00:00:00 2001
>From: Philip Withnall <withnall@endlessm.com>
>Date: Mon, 6 Feb 2017 13:02:22 +0000
>Subject: [PATCH] tools: Improve argument validation in dbus-spam
>
>Check that at most one argument which sets the payload is provided, so
>the allocated payload is not overwritten and leaked.
>
>Coverity ID: 54759
>
>Signed-off-by: Philip Withnall <withnall@endlessm.com>
>
>https://bugs.freedesktop.org/show_bug.cgi?id=99693
>---
> tools/dbus-spam.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
>diff --git a/tools/dbus-spam.c b/tools/dbus-spam.c
>index 9d2b04c..a8a1f08 100644
>--- a/tools/dbus-spam.c
>+++ b/tools/dbus-spam.c
>@@ -179,6 +179,17 @@ dbus_test_tool_spam (int argc, char **argv)
>     {
>       const char *arg = argv[i];
> 
>+      if (payload != NULL &&
>+          (strstr (arg, "--payload=") == arg ||
>+           strcmp (arg, "--stdin") == 0 ||
>+           strcmp (arg, "--message-stdin") == 0 ||
>+           strcmp (arg, "--random-size") == 0))
>+        {
>+          fprintf (stderr, "At most one of --payload, --stdin, --message-stdin "
>+                           "and --random-size may be specified\n");
>+          exit (1);
>+        }
>+
>       if (strcmp (arg, "--system") == 0)
>         {
>           type = DBUS_BUS_SYSTEM;
>-- 
>2.9.3

Actions: View | Splinter Review

Attachments on bug 99693: 129362 | 129389

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.