Attachment 127125 Details for Bug 98157 – bus_driver_handle_message: reject ActivationFailure if unprivileged

[patch] bus_driver_handle_message: reject ActivationFailure if unprivileged

0002-bus_driver_handle_message-reject-ActivationFailure-i.patch (text/plain), 1.43 KB, created by Simon McVittie on 2016-10-07 20:29:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2016-10-07 20:29:47 UTC

Size: 1.43 KB

patch

obsolete

>From 1185bcd4897cbba268754833d087100bade2abfe Mon Sep 17 00:00:00 2001
>From: Simon McVittie <smcv@debian.org>
>Date: Fri, 7 Oct 2016 21:25:08 +0100
>Subject: [PATCH 2/3] bus_driver_handle_message: reject ActivationFailure if
> unprivileged
>
>Specifically, this will allow ActivationFailure messages from our
>own uid or from root, but reject them otherwise, even if the bus
>configuration for who can own org.freedesktop.systemd1 is entirely
>wrong due to something like CVE-2014-8148.
>
>Signed-off-by: Simon McVittie <smcv@debian.org>
>---
> bus/driver.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
>diff --git a/bus/driver.c b/bus/driver.c
>index 39157bd..24ac44f 100644
>--- a/bus/driver.c
>+++ b/bus/driver.c
>@@ -2637,6 +2637,15 @@ bus_driver_handle_message (DBusConnection *connection,
>       BusContext *context;
>       DBusConnection *systemd;
> 
>+      /* This is a directed signal, not a method call, so the log message
>+       * is a little weird (it talks about "calling" ActivationFailure),
>+       * but it's close enough */
>+      if (!bus_driver_check_caller_is_privileged (connection,
>+                                                  transaction,
>+                                                  message,
>+                                                  error))
>+        return FALSE;
>+
>       context = bus_connection_get_context (connection);
>       systemd = bus_driver_get_owner_of_name (connection,
>           "org.freedesktop.systemd1");
>-- 
>2.9.3
>

Actions: View | Splinter Review

Attachments on bug 98157: 127124 | 127125 | 127127 | 127128

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.