Attachment 126156 Details for Bug 97532 – patch

[patch] patch

0001-glsl-linker-print-only-warning-if-uniform-was-not-us.patch (text/plain), 1.76 KB, created by Tapani Pälli on 2016-09-01 10:33:45 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tapani Pälli

Created: 2016-09-01 10:33:45 UTC

Size: 1.76 KB

patch

obsolete

>From a83fc4183f7f8b2ac9913f7adcce435a147d6556 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Tapani=20P=C3=A4lli?= <tapani.palli@intel.com>
>Date: Thu, 1 Sep 2016 12:01:11 +0300
>Subject: [PATCH] glsl/linker: print only warning if uniform was not used
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>loosen the check for cross-stage validation of uniform precision
>qualifiers, emit only warning if existing uniform was not used
>(not read or written to).
>
>Signed-off-by: Tapani PÃ¤lli <tapani.palli@intel.com>
>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97532
>---
> src/compiler/glsl/linker.cpp | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
>diff --git a/src/compiler/glsl/linker.cpp b/src/compiler/glsl/linker.cpp
>index c95edf3..df36966 100644
>--- a/src/compiler/glsl/linker.cpp
>+++ b/src/compiler/glsl/linker.cpp
>@@ -1155,10 +1155,16 @@ cross_validate_globals(struct gl_shader_program *prog,
>          }
> 
>          if (prog->IsES && existing->data.precision != var->data.precision) {
>-            linker_error(prog, "declarations for %s `%s` have "
>-                         "mismatching precision qualifiers\n",
>-                         mode_string(var), var->name);
>+            if (existing->data.used) {
>+               linker_error(prog, "declarations for %s `%s` have "
>+                            "mismatching precision qualifiers\n",
>+                            mode_string(var), var->name);
>             return;
>+            } else {
>+               linker_warning(prog, "declarations for %s `%s` have "
>+                              "mismatching precision qualifiers\n",
>+                              mode_string(var), var->name);
>+            }
>          }
>       } else
>          variables->add_variable(var);
>-- 
>2.7.4
>

Actions: View | Splinter Review

Attachments on bug 97532: 126156 | 126582 | 127853

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.