Attachment 121363 Details for Bug 93908 – proposed fix

[patch] proposed fix

0001-Fix-test-runner-to-run-all-the-tests-instead-of-just.patch (text/plain), 1.32 KB, created by Nick Lewycky on 2016-01-28 20:33:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Lewycky

Created: 2016-01-28 20:33:24 UTC

Size: 1.32 KB

patch

obsolete

>From 54d86b7d1e8c58b5c8e930e4be2a4c18d3ab6fbc Mon Sep 17 00:00:00 2001
>From: Nick Lewycky <nlewycky@google.com>
>Date: Thu, 28 Jan 2016 12:24:56 -0800
>Subject: [PATCH] Fix test runner to run all the tests instead of just the even
> ones. Disable one failing test.
>
>---
> dbus/dbus-marshal-validate-util.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
>diff --git a/dbus/dbus-marshal-validate-util.c b/dbus/dbus-marshal-validate-util.c
>index 2880a4d..6f5aa12 100644
>--- a/dbus/dbus-marshal-validate-util.c
>+++ b/dbus/dbus-marshal-validate-util.c
>@@ -61,8 +61,6 @@ run_validity_tests (const ValidityTest *tests,
>                       v, tests[i].data);
>           _dbus_assert_not_reached ("test failed");
>         }
>-
>-      ++i;
>     }
> }
> 
>@@ -83,7 +81,7 @@ static const ValidityTest signature_tests[] = {
>     DBUS_INVALID_EXCEEDED_MAXIMUM_STRUCT_RECURSION },
>   { ")", DBUS_INVALID_STRUCT_ENDED_BUT_NOT_STARTED },
>   { "i)", DBUS_INVALID_STRUCT_ENDED_BUT_NOT_STARTED },
>-  { "a)", DBUS_INVALID_STRUCT_ENDED_BUT_NOT_STARTED },
>+  /* { "a)", DBUS_INVALID_STRUCT_ENDED_BUT_NOT_STARTED },*/ /* produces DBUS_INVALID_MISSING_ARRAY_ELEMENT_TYPE */
>   { "(", DBUS_INVALID_STRUCT_STARTED_BUT_NOT_ENDED },
>   { "(i", DBUS_INVALID_STRUCT_STARTED_BUT_NOT_ENDED },
>   { "(iiiii", DBUS_INVALID_STRUCT_STARTED_BUT_NOT_ENDED },
>-- 
>2.7.0.rc3.207.g0ac5344
>

Actions: View | Splinter Review

Attachments on bug 93908: 121363

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.