Attachment 120293 Details for Bug 93205 – Revised patch for misuse enum comparison fix

[patch] Revised patch for misuse enum comparison fix

0001-Misuse-of-Enum-in-bus_config_load-during-comparison.patch (text/plain), 1019 bytes, created by Deepika Aggarwal on 2015-12-03 06:19:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Deepika Aggarwal

Created: 2015-12-03 06:19:23 UTC

Size: 1019 bytes

patch

obsolete

>From e9023ad88c256b324c3e1b3db5b73bae8a21fac8 Mon Sep 17 00:00:00 2001
>From: Deepika Aggarwal <deepika.a@samsung.com>
>Date: Thu, 3 Dec 2015 11:22:56 +0530
>Subject: [PATCH] Misuse of Enum in bus_config_load() during comparison
>Description: Comparison check improved with XML_STATUS_ERROR enum value check
>
>Signed-off-by: Deepika Aggarwal <deepika.a@samsung.com>
>---
> bus/config-loader-expat.c |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/bus/config-loader-expat.c b/bus/config-loader-expat.c
>index b571fda..5399fd2 100644
>--- a/bus/config-loader-expat.c
>+++ b/bus/config-loader-expat.c
>@@ -242,7 +242,7 @@ bus_config_load (const DBusString      *file,
> 
>     data_str = _dbus_string_get_const_data (&data);
> 
>-    if (!XML_Parse (expat, data_str, _dbus_string_get_length (&data), TRUE))
>+    if (XML_Parse (expat, data_str, _dbus_string_get_length (&data), TRUE) == XML_STATUS_ERROR )
>       {
>         if (context.error != NULL &&
>             !dbus_error_is_set (context.error))
>-- 
>1.7.9.5
>

Actions: View | Splinter Review

Attachments on bug 93205: 120262 | 120293 | 120294

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.