Attachment 117681 Details for Bug 91636 – poposed patch

[patch] poposed patch

0001-xfree86-Prevent-crash-with-non-pci-graphics-cards.patch (text/plain), 1.12 KB, created by Sjoerd Simons on 2015-08-14 12:21:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Sjoerd Simons

Created: 2015-08-14 12:21:24 UTC

Size: 1.12 KB

patch

obsolete

>From 35133852e7a739bc30d0bc6cb6fbc640192975ae Mon Sep 17 00:00:00 2001
>From: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
>Date: Fri, 14 Aug 2015 14:14:16 +0200
>Subject: [PATCH] xfree86: Prevent crash with non-pci graphics cards
>
>If a device supports pci but doesn't have its graphics on PCI their
>busid might very well be NULL. So check that for that before passing
>NULL to strncmp and crashing.
>
>Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
>---
> hw/xfree86/common/xf86platformBus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/hw/xfree86/common/xf86platformBus.c b/hw/xfree86/common/xf86platformBus.c
>index f1e9423..bff5862 100644
>--- a/hw/xfree86/common/xf86platformBus.c
>+++ b/hw/xfree86/common/xf86platformBus.c
>@@ -290,7 +290,7 @@ xf86platformProbe(void)
>     for (i = 0; i < xf86_num_platform_devices; i++) {
>         char *busid = xf86_platform_odev_attributes(i)->busid;
> 
>-        if (pci && (strncmp(busid, "pci:", 4) == 0)) {
>+        if (pci && busid && (strncmp(busid, "pci:", 4) == 0)) {
>             platform_find_pci_info(&xf86_platform_devices[i], busid);
>         }
>     }
>-- 
>2.5.0
>

Actions: View | Splinter Review

Attachments on bug 91636: 117681

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.