Attachment 116917 Details for Bug 90952 – Add test-case to confirm that dbus_connection_set_route_peer_messages() is enough

[patch] Add test-case to confirm that dbus_connection_set_route_peer_messages() is enough

0002-Add-test-case-to-confirm-that-dbus_connection_set_ro.patch (text/plain), 1.79 KB, created by Simon McVittie on 2015-07-03 13:05:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2015-07-03 13:05:39 UTC

Size: 1.79 KB

patch

obsolete

>From 54f350673d2c42cf0c194bdc5850a7f89c95a3d9 Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Fri, 3 Jul 2015 13:59:44 +0100
>Subject: [PATCH 2/2] Add test-case to confirm that
> dbus_connection_set_route_peer_messages() is enough
>
>Bug: https://bugs.freedesktop.org/show_bug.cgi?id=90952
>Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
>---
> test/monitor.c | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
>diff --git a/test/monitor.c b/test/monitor.c
>index 6c77bab..c099139 100644
>--- a/test/monitor.c
>+++ b/test/monitor.c
>@@ -454,6 +454,8 @@ become_monitor (Fixture *f)
>   int i;
>   dbus_uint32_t zero = 0;
> 
>+  dbus_connection_set_route_peer_messages (f->monitor, TRUE);
>+
>   if (f->config != NULL && f->config->match_rules != NULL)
>     match_rules = f->config->match_rules;
>   else
>@@ -928,6 +930,28 @@ test_method_call (Fixture *f,
> 
>   become_monitor (f);
> 
>+  /* regression test for
>+   * https://bugs.freedesktop.org/show_bug.cgi?id=90952 */
>+  m = dbus_message_new_method_call (f->recipient_name, "/foo",
>+      DBUS_INTERFACE_PEER, "Ping");
>+  dbus_connection_send (f->sender, m, NULL);
>+  dbus_message_unref (m);
>+
>+  while (g_queue_get_length (&f->monitored) < 2)
>+    test_main_context_iterate (f->ctx, TRUE);
>+
>+  m = g_queue_pop_head (&f->monitored);
>+  assert_method_call (m, f->sender_name, f->recipient_name, "/foo",
>+      DBUS_INTERFACE_PEER, "Ping", "");
>+  dbus_message_unref (m);
>+
>+  m = g_queue_pop_head (&f->monitored);
>+  assert_method_reply (m, f->recipient_name, f->sender_name, "");
>+  dbus_message_unref (m);
>+
>+  m = g_queue_pop_head (&f->monitored);
>+  g_assert (m == NULL);
>+
>   m = dbus_message_new_method_call (f->recipient_name, "/foo", "com.example.bar",
>       "Call1");
>   dbus_connection_send (f->sender, m, NULL);
>-- 
>2.1.4
>

Actions: View | Splinter Review

Attachments on bug 90952: 116916 | 116917

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.