Attachment 114787 Details for Bug 89852 – location: More sanity checks when computing speed

[patch] location: More sanity checks when computing speed

0006-location-More-sanity-checks-when-computing-speed.patch (text/plain), 1.12 KB, created by Fabrice Bellet on 2015-03-31 19:54:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Fabrice Bellet

Created: 2015-03-31 19:54:27 UTC

Size: 1.12 KB

patch

obsolete

>From 2b4b02fcb26f5acba9b251c162fa3265da49a632 Mon Sep 17 00:00:00 2001
>From: Fabrice Bellet <fabrice@bellet.info>
>Date: Tue, 31 Mar 2015 11:50:13 +0200
>Subject: [PATCH] location: More sanity checks when computing speed
>
>We now avoid a division by zero error in the speed update from previous
>location, by checking that the timestamp has changed since previous
>update.
>
>https://bugs.freedesktop.org/show_bug.cgi?id=89852
>---
> src/gclue-location.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/src/gclue-location.c b/src/gclue-location.c
>index eb4877a..0107937 100644
>--- a/src/gclue-location.c
>+++ b/src/gclue-location.c
>@@ -267,6 +267,10 @@ gclue_location_set_speed_from_prev_location (GClueLocation *location,
> 
>         timestamp = geocode_location_get_timestamp (gloc);
>         prev_timestamp = geocode_location_get_timestamp (prev_gloc);
>+        if (prev_timestamp == timestamp) {
>+               location->priv->speed = GCLUE_LOCATION_SPEED_UNKNOWN;
>+               return;
>+        }
> 
>         speed = geocode_location_get_distance_from (gloc, prev_gloc) *
>                 1000.0 / (timestamp - prev_timestamp);
>-- 
>2.1.0
>

Actions: View | Splinter Review

Attachments on bug 89852: 114787 | 114873 | 114874 | 114924 | 114926 | 114958 | 114959 | 114963 | 114964 | 114981 | 114982 | 114983 | 114984 | 114985 | 114986 | 114993 | 114994 | 114995 | 114996 | 114997 | 114998

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.