Attachment 113694 Details for Bug 89243 – marshalling tests: fix an incorrect use of memcmp

[patch] marshalling tests: fix an incorrect use of memcmp

0003-marshalling-tests-fix-an-incorrect-use-of-memcmp.patch (text/plain), 1.24 KB, created by Simon McVittie on 2015-02-20 18:12:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2015-02-20 18:12:47 UTC

Size: 1.24 KB

patch

obsolete

>From 381c5d42e36d668419ee8d1b6e3d6ea53c75a9fa Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Fri, 20 Feb 2015 16:01:45 +0000
>Subject: [PATCH 3/3] marshalling tests: fix an incorrect use of memcmp
>
>---
> dbus/dbus-marshal-basic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/dbus/dbus-marshal-basic.c b/dbus/dbus-marshal-basic.c
>index 9bb5b76..74fe3f9 100644
>--- a/dbus/dbus-marshal-basic.c
>+++ b/dbus/dbus-marshal-basic.c
>@@ -1580,7 +1580,7 @@ swap_test_array (void *array,
> #define DEMARSHAL_FIXED_ARRAY_AND_CHECK(typename, byte_order, literal)                  \
>   do {                                                                                  \
>     DEMARSHAL_FIXED_ARRAY (typename, byte_order);                                       \
>-    if (memcmp (literal, v_ARRAY_##typename, sizeof (literal) != 0))                    \
>+    if (memcmp (literal, v_ARRAY_##typename, sizeof (literal)) != 0)                    \
>       {                                                                                 \
>         _dbus_verbose ("MARSHALED DATA\n");                                             \
>         _dbus_verbose_bytes_of_string (&str, dump_pos,                                  \
>-- 
>2.1.4
>

Actions: View | Splinter Review

Attachments on bug 89243: 113693 | 113694

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.