Attachment 112851 Details for Bug 88811 – [master only] Add a regression test for making systemd activation appear to fail

[patch] [master only] Add a regression test for making systemd activation appear to fail

0003-Add-a-regression-test-for-making-systemd-activation-.patch (text/plain), 1.88 KB, created by Simon McVittie on 2015-01-26 20:52:58 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2015-01-26 20:52:58 UTC

Size: 1.88 KB

patch

obsolete

>From e779fb96553c7fe0e0ac3f82db22250e77f2f418 Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Mon, 26 Jan 2015 20:07:14 +0000
>Subject: [PATCH 3/4] Add a regression test for making systemd activation
> appear to fail
>
>---
> test/sd-activation.c | 31 +++++++++++++++++++++++++++++++
> 1 file changed, 31 insertions(+)
>
>diff --git a/test/sd-activation.c b/test/sd-activation.c
>index 14e4ae8..1a9c9de 100644
>--- a/test/sd-activation.c
>+++ b/test/sd-activation.c
>@@ -211,6 +211,37 @@ test_activation (Fixture *f,
>       "org.freedesktop.systemd1");
>   dbus_message_unref (m);
> 
>+  /* A malicious process tries to disrupt the activation.
>+   * In a more realistic scenario this would be another parallel
>+   * connection. */
>+  m = dbus_message_new_signal ("/org/freedesktop/systemd1",
>+      "org.freedesktop.systemd1.Activator", "ActivationFailure");
>+  if (!dbus_message_set_destination (m, "org.freedesktop.DBus"))
>+    g_error ("OOM");
>+
>+  do
>+    {
>+      const char *unit = "dbus-com.example.SystemdActivatable2.service";
>+      const char *error_name = "com.example.Malice";
>+      const char *error_message = "I'm on yr bus, making yr activations fail";
>+
>+      if (!dbus_message_append_args (m,
>+            DBUS_TYPE_STRING, &unit,
>+            DBUS_TYPE_STRING, &error_name,
>+            DBUS_TYPE_STRING, &error_message,
>+            DBUS_TYPE_INVALID))
>+        g_error ("OOM");
>+    }
>+  while (0);
>+
>+  dbus_connection_send (f->caller, m, NULL);
>+  dbus_message_unref (m);
>+
>+  /* This is just to make sure that the malicious message has arrived and
>+   * been processed by the dbus-daemon, i.e. @caller won the race
>+   * with @activated. */
>+  take_well_known_name (f, f->caller, "com.example.Sync");
>+
>   /* The activatable service takes its name. Here I'm faking it by using
>    * an existing connection; in real life it would be yet another
>    * connection. */
>-- 
>2.1.4
>

Actions: View | Splinter Review

Attachments on bug 88811: 112849 | 112850 | 112851 | 112852 | 112911 | 112912 | 112913

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.