Attachment 11114 Details for Bug 6502 – Previous patch updated for Fedora 7's xorg-x11-server-Xorg-1.3.0.0-9.fc7

[patch] Previous patch updated for Fedora 7's xorg-x11-server-Xorg-1.3.0.0-9.fc7

xserver-1.3.0-bug-6502.patch (text/plain), 1.09 KB, created by Dale Sedivec on 2007-08-12 20:03:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Dale Sedivec

Created: 2007-08-12 20:03:57 UTC

Size: 1.09 KB

patch

obsolete

>--- rrscreen.c.foo	2007-04-09 17:23:21.000000000 -0400
>+++ rrscreen.c	2007-08-07 00:05:02.000000000 -0400
>@@ -764,7 +764,6 @@
>     pScrPriv = rrGetScrPriv(pScreen);
>     
>     time = ClientTimeToServerTime(stuff->timestamp);
>-    configTime = ClientTimeToServerTime(stuff->configTimestamp);
>     
>     if (!pScrPriv)
>     {
>@@ -784,11 +783,15 @@
>     }
>     
>     /*
>-     * if the client's config timestamp is not the same as the last config
>+     * If the client's config timestamp is not the same as the last config
>      * timestamp, then the config information isn't up-to-date and
>-     * can't even be validated
>+     * can't even be validated.
>+     *
>+     * Note that the client only knows about the milliseconds part of the
>+     * timestamp, so using CompareTimeStamps here would cause randr to suddenly
>+     * stop working after several hours have passed (freedesktop bug #6502).
>      */
>-    if (CompareTimeStamps (configTime, pScrPriv->lastConfigTime) != 0)
>+    if (stuff->configTimestamp != pScrPriv->lastConfigTime.milliseconds)
>     {
> 	rep.status = RRSetConfigInvalidConfigTime;
> 	goto sendReply;

Actions: View | Splinter Review

Attachments on bug 6502: 5577 | 5578 | 6494 | 6495 | 8287 | 8288 | 8585 | 8586 | 11114

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.